1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
// Copyright 2015-2020 Parity Technologies (UK) Ltd.
// This file is part of OpenEthereum.

// OpenEthereum is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.

// OpenEthereum is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
// GNU General Public License for more details.

// You should have received a copy of the GNU General Public License
// along with OpenEthereum.  If not, see <http://www.gnu.org/licenses/>.

/// Validator set maintained in a contract, updated using `getValidators` method.
/// It can also report validators for misbehaviour with two levels: `reportMalicious` and `reportBenign`.
use std::sync::Weak;

use bytes::Bytes;
use ethereum_types::{Address, H256, U256};
use machine::{AuxiliaryData, Call, EthereumMachine};
use parking_lot::RwLock;
use types::{header::Header, ids::BlockId, transaction, BlockNumber};

use client::{traits::TransactionRequest, EngineClient};

use error::Error as EthcoreError;

use super::{safe_contract::ValidatorSafeContract, SimpleList, SystemCall, ValidatorSet};

use_contract!(validator_report, "res/contracts/validator_report.json");

/// A validator contract with reporting.
pub struct ValidatorContract {
    contract_address: Address,
    validators: ValidatorSafeContract,
    client: RwLock<Option<Weak<dyn EngineClient>>>, // TODO [keorn]: remove
    posdao_transition: Option<BlockNumber>,
}

impl ValidatorContract {
    pub fn new(contract_address: Address, posdao_transition: Option<BlockNumber>) -> Self {
        ValidatorContract {
            contract_address,
            validators: ValidatorSafeContract::new(contract_address, posdao_transition),
            client: RwLock::new(None),
            posdao_transition,
        }
    }

    fn transact(
        &self,
        data: Bytes,
        gas_price: Option<U256>,
        client: &dyn EngineClient,
    ) -> Result<(), String> {
        let full_client = client.as_full_client().ok_or("No full client!")?;
        let tx_request = TransactionRequest::call(self.contract_address, data).gas_price(gas_price);
        match full_client.transact(tx_request) {
            Ok(()) | Err(transaction::Error::AlreadyImported) => Ok(()),
            Err(e) => Err(e.to_string())?,
        }
    }

    fn do_report_malicious(
        &self,
        address: &Address,
        block: BlockNumber,
        proof: Bytes,
    ) -> Result<(), EthcoreError> {
        let client = self
            .client
            .read()
            .as_ref()
            .and_then(Weak::upgrade)
            .ok_or("No client!")?;
        let latest = client
            .block_header(BlockId::Latest)
            .ok_or("No latest block!")?;
        if !self.contains(&latest.parent_hash(), address) {
            warn!(target: "engine", "Not reporting {} on block {}: Not a validator", address, block);
            return Ok(());
        }
        let data =
            validator_report::functions::report_malicious::encode_input(*address, block, proof);
        self.validators
            .enqueue_report(*address, block, data.clone());
        let gas_price = self.report_gas_price(latest.number());
        self.transact(data, gas_price, &*client)?;
        warn!(target: "engine", "Reported malicious validator {} at block {}", address, block);
        Ok(())
    }

    fn do_report_benign(&self, address: &Address, block: BlockNumber) -> Result<(), EthcoreError> {
        let client = self
            .client
            .read()
            .as_ref()
            .and_then(Weak::upgrade)
            .ok_or("No client!")?;
        let latest = client
            .block_header(BlockId::Latest)
            .ok_or("No latest block!")?;
        let data = validator_report::functions::report_benign::encode_input(*address, block);
        let gas_price = self.report_gas_price(latest.number());
        self.transact(data, gas_price, &*client)?;
        warn!(target: "engine", "Benign report for validator {} at block {}", address, block);
        Ok(())
    }

    /// Returns the gas price for report transactions.
    ///
    /// After `posdaoTransition`, this is zero. Otherwise it is the default (`None`).
    fn report_gas_price(&self, block: BlockNumber) -> Option<U256> {
        if self.posdao_transition? <= block {
            Some(0.into())
        } else {
            None
        }
    }
}

impl ValidatorSet for ValidatorContract {
    fn default_caller(&self, id: ::types::ids::BlockId) -> Box<Call> {
        self.validators.default_caller(id)
    }

    fn generate_engine_transactions(
        &self,
        first: bool,
        header: &Header,
        call: &mut SystemCall,
    ) -> Result<Vec<(Address, Bytes)>, EthcoreError> {
        self.validators
            .generate_engine_transactions(first, header, call)
    }

    fn on_close_block(&self, header: &Header, address: &Address) -> Result<(), EthcoreError> {
        self.validators.on_close_block(header, address)
    }

    fn on_epoch_begin(
        &self,
        first: bool,
        header: &Header,
        call: &mut SystemCall,
    ) -> Result<(), ::error::Error> {
        self.validators.on_epoch_begin(first, header, call)
    }

    fn genesis_epoch_data(&self, header: &Header, call: &Call) -> Result<Vec<u8>, String> {
        self.validators.genesis_epoch_data(header, call)
    }

    fn is_epoch_end(&self, first: bool, chain_head: &Header) -> Option<Vec<u8>> {
        self.validators.is_epoch_end(first, chain_head)
    }

    fn signals_epoch_end(
        &self,
        first: bool,
        header: &Header,
        aux: AuxiliaryData,
    ) -> ::engines::EpochChange<EthereumMachine> {
        self.validators.signals_epoch_end(first, header, aux)
    }

    fn epoch_set(
        &self,
        first: bool,
        machine: &EthereumMachine,
        number: BlockNumber,
        proof: &[u8],
    ) -> Result<(SimpleList, Option<H256>), ::error::Error> {
        self.validators.epoch_set(first, machine, number, proof)
    }

    fn contains_with_caller(&self, bh: &H256, address: &Address, caller: &Call) -> bool {
        self.validators.contains_with_caller(bh, address, caller)
    }

    fn get_with_caller(&self, bh: &H256, nonce: usize, caller: &Call) -> Address {
        self.validators.get_with_caller(bh, nonce, caller)
    }

    fn count_with_caller(&self, bh: &H256, caller: &Call) -> usize {
        self.validators.count_with_caller(bh, caller)
    }

    fn report_malicious(
        &self,
        address: &Address,
        _set_block: BlockNumber,
        block: BlockNumber,
        proof: Bytes,
    ) {
        if let Err(s) = self.do_report_malicious(address, block, proof) {
            warn!(target: "engine", "Validator {} could not be reported ({}) on block {}", address, s, block);
        }
    }

    fn report_benign(&self, address: &Address, _set_block: BlockNumber, block: BlockNumber) {
        if let Err(s) = self.do_report_benign(address, block) {
            warn!(target: "engine", "Validator {} could not be reported ({}) on block {}", address, s, block);
        }
    }

    fn register_client(&self, client: Weak<dyn EngineClient>) {
        self.validators.register_client(client.clone());
        *self.client.write() = Some(client);
    }
}

#[cfg(test)]
mod tests {
    use super::{super::ValidatorSet, ValidatorContract};
    use accounts::AccountProvider;
    use bytes::ToPretty;
    use call_contract::CallContract;
    use client::{traits::TransactionRequest, BlockChainClient, BlockInfo, ChainInfo};
    use ethabi::FunctionOutputDecoder;
    use ethereum_types::{Address, H520};
    use hash::keccak;
    use miner::{self, MinerService};
    use rlp::encode;
    use rustc_hex::FromHex;
    use spec::Spec;
    use std::sync::Arc;
    use test_helpers::generate_dummy_client_with_spec;
    use types::{header::Header, ids::BlockId};

    #[test]
    fn fetches_validators() {
        let client = generate_dummy_client_with_spec(Spec::new_validator_contract);
        let addr: Address = "0000000000000000000000000000000000000005".parse().unwrap();
        let vc = Arc::new(ValidatorContract::new(addr, None));
        vc.register_client(Arc::downgrade(&client) as _);
        let last_hash = client.best_block_header().hash();
        assert!(vc.contains(
            &last_hash,
            &"7d577a597b2742b498cb5cf0c26cdcd726d39e6e"
                .parse::<Address>()
                .unwrap()
        ));
        assert!(vc.contains(
            &last_hash,
            &"82a978b3f5962a5b0957d9ee9eef472ee55b42f1"
                .parse::<Address>()
                .unwrap()
        ));
    }

    #[test]
    fn reports_validators() {
        let tap = Arc::new(AccountProvider::transient_provider());
        let v1 = tap.insert_account(keccak("1").into(), &"".into()).unwrap();
        let client = generate_dummy_client_with_spec(Spec::new_validator_contract);
        client
            .engine()
            .register_client(Arc::downgrade(&client) as _);
        let validator_contract = "0000000000000000000000000000000000000005"
            .parse::<Address>()
            .unwrap();

        // Make sure reporting can be done.
        client
            .miner()
            .set_gas_range_target((1_000_000.into(), 1_000_000.into()));
        let signer = Box::new((tap.clone(), v1, "".into()));
        client.miner().set_author(miner::Author::Sealer(signer));

        // Check a block that is a bit in future, reject it but don't report the validator.
        let mut header = Header::default();
        let seal = vec![encode(&4u8), encode(&(H520::default().as_bytes()))];
        header.set_seal(seal);
        header.set_author(v1);
        header.set_number(2);
        header.set_parent_hash(client.chain_info().best_block_hash);
        assert!(client.engine().verify_block_external(&header).is_err());
        client.engine().step();
        assert_eq!(client.chain_info().best_block_number, 0);
        // `reportBenign` when the designated proposer releases block from the future (bad clock).
        assert!(client.engine().verify_block_basic(&header).is_err());

        // Now create one that is more in future. That one should be rejected and validator should be reported.
        let mut header = Header::default();
        let seal = vec![encode(&8u8), encode(&(H520::default().as_bytes()))];
        header.set_seal(seal);
        header.set_author(v1);
        header.set_number(2);
        header.set_parent_hash(client.chain_info().best_block_hash);
        // `reportBenign` when the designated proposer releases block from the future (bad clock).
        assert!(client.engine().verify_block_basic(&header).is_err());
        // Seal a block.
        client.engine().step();
        assert_eq!(client.chain_info().best_block_number, 1);
        // Check if the unresponsive validator is `disliked`. "d8f2e0bf" accesses the field `disliked`..
        assert_eq!(
            client
                .call_contract(
                    BlockId::Latest,
                    validator_contract,
                    "d8f2e0bf".from_hex().unwrap()
                )
                .unwrap()
                .to_hex(),
            "0000000000000000000000007d577a597b2742b498cb5cf0c26cdcd726d39e6e"
        );
        // Simulate a misbehaving validator by handling a double proposal.
        let header = client.best_block_header();
        assert!(client
            .engine()
            .verify_block_family(&header, &header)
            .is_err());
        // Seal a block.
        client.engine().step();
        client.engine().step();
        assert_eq!(client.chain_info().best_block_number, 2);
        let (data, decoder) =
            super::validator_report::functions::malice_reported_for_block::call(v1, 1);
        let reported_enc = client
            .call_contract(BlockId::Latest, validator_contract, data)
            .expect("call failed");
        assert_ne!(
            Vec::<Address>::new(),
            decoder.decode(&reported_enc).expect("decoding failed")
        );

        // Check if misbehaving validator was removed.

        client
            .transact(TransactionRequest::call(
                Default::default(),
                Default::default(),
            ))
            .unwrap();
        client.engine().step();
        client.engine().step();
        assert_eq!(client.chain_info().best_block_number, 2);
    }
}